-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove tools and dev tools AngularJS controllers #6544
Conversation
- Remove dev tools and tools controllers - Replace the render using an AngularJS template by a ReactJS component - Create ToolsRouter component to manage the routing of Dev Tools and Ruleset Test views - Move logic and render of dev tools to a ReactJS component - Remove unused definitions of controllers and variables in AngularJS
…o feat/6536-remove-angularjs-controller-tools
…o feat/6536-remove-angularjs-controller-tools
TestLegend: UI
Details 🟢 Go to Server management > Dev Tools and the application should be visibleFirefox - ⚫ Safari - ⚫ 🟢 In Server management > Dev Tools, test the API endpoint suggestions are working as previouslyFirefox - ⚫ Safari - ⚫ 🟢 In Server management > Dev Tools, run API requests, the response should be displayed in the reghit sideFirefox - ⚫ Safari - ⚫ 🟢 In Server management > Dev Tools, click on the button to get more information about the current API endpoint in the editor of the left sideFirefox - ⚫ Safari - ⚫ 🟢 In Server management > Dev Tools, click on the link to get information about the API reference that is located in the top right cornerFirefox - ⚫ Safari - ⚫ 🟢 In Server management > Dev Tools, click on the button to export the output of API request to JSON. Verify the file content has the same content that was displayed in the output view when this was exportedFirefox - ⚫ Safari - ⚫ 🟢 Go to Server management > Dev Tools and the breadcrumb should display the name of the applicationFirefox - ⚫ Safari - ⚫ 🟢 Go to Server management > Ruleset Test and the application should be visibleFirefox - ⚫ Safari - ⚫ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CR: ✅
Test: ✅
ba3f2f4
|
|
|
Description
This pull request removes the tools and dev tools AngularJS controllers.
Changes:
Ruleset Test views
Issues Resolved
#6539
Evidence
Test
Legend:
⚫: none
🟢: pass
🟡: warning
🔴: fail
⚪: not applicable
UI
Details
⚫ Go to Server management > Dev Tools and the application should be visible
Chrome - ⚫
Firefox - ⚫
Safari - ⚫
⚫ In Server management > Dev Tools, test the API endpoint suggestions are working as previously
Chrome - ⚫
Firefox - ⚫
Safari - ⚫
⚫ In Server management > Dev Tools, run API requests, the response should be displayed in the reghit side
Chrome - ⚫
Firefox - ⚫
Safari - ⚫
⚫ In Server management > Dev Tools, click on the button to get more information about the current API endpoint in the editor of the left side
Chrome - ⚫
Firefox - ⚫
Safari - ⚫
⚫ In Server management > Dev Tools, click on the link to get information about the API referene that is located in the top right corner
Chrome - ⚫
Firefox - ⚫
Safari - ⚫
⚫ In Server management > Dev Tools, click on the button to export the output of API request to JSON. Verify the file content has the same content that was displayed in the output view when this was exported
Chrome - ⚫
Firefox - ⚫
Safari - ⚫
⚫ Go to Server management > Dev Tools and the breadcrumb should display the name of the application
Chrome - ⚫
Firefox - ⚫
Safari - ⚫
⚫ Go to Server management > Ruleset Test and the application should be visible
Chrome - ⚫
Firefox - ⚫
Safari - ⚫
⚫ Go to Server management > Ruleset Test and the breadcrumb should display the name of the application
Chrome - ⚫
Firefox - ⚫
Safari - ⚫
Check List
yarn test:jest